Skip to content
Snippets Groups Projects

Merge of all branches of Fabian PK (related to skills)

Merged Merge of all branches of Fabian PK (related to skills)
test/merge-branch-skills-to-master into master
Merged Fabian Tërnava requested to merge test/merge-branch-skills-to-master into master
  1. Mar 13, 2023
  3. Mar 01, 2023
  5. Feb 21, 2023
  7. Feb 20, 2023
  9. Feb 19, 2023
  11. Feb 18, 2023
    • Tobias Bodmer's avatar
      Way better parse error reporting · c28d544e
      Tobias Bodmer authored 
      noticing broken items, even when they are not touched. Also coloring
their parents in an orange color, so that the error is noticable even
when not expanded.

For better generality (and was useful for error reporting): All widgets
introduced inherit from a common base class: CustomWidget. It holds a
signal definition that can be used to directly forward signals to its
QTreeWidgetItem underneath.
      c28d544e
  13. Feb 17, 2023
  15. Feb 16, 2023
  17. Feb 15, 2023
  19. Feb 13, 2023
  21. Feb 09, 2023
    • Tobias Bodmer's avatar
      publish TODO also · 72653b3a
      Tobias Bodmer authored
      72653b3a
    • Tobias Bodmer's avatar
      Many fixes & refactoring & add Quaternions · d7f046dd
      Tobias Bodmer authored 
      - add QuaternionWidget
- remove old modal code
- remove Copy and clone of AronTreeWidgetItem
- add recognition of duplicate dict keys
- add countermeasure to tabbing into unchangeable key fields
- make aronType const in AronTreeWidget
- flag tuple code as untested, since aron is currently broken there
- fix weird std::locals setting in AronTreeWidgetSetter.cpp, which causes floating numbers to print as 12,345 with std::to_string()
- add usage of std::launder to make reinterpret_cast more save within the usage of NDArray
      d7f046dd
  23. Jan 30, 2023
  25. Jan 12, 2023
    • Tobias Bodmer's avatar
      Convert IntEnum && list #elements && list conv fix · 2fec2bd3
      Tobias Bodmer authored 
      Implement IntEnum parsing by both value and string name. The String name
is hadled first.
Also added a feature which displays the contained number of children at
the otherwise empty value field for lists.

Fixed a bug, where the converter visitor sometimes didn't get
called with the visit() method.

Also AronTreeWidgetConverter recursively called itself when listTypes
were involved.
      2fec2bd3
  27. Jan 09, 2023
  29. Dec 20, 2022
  31. Dec 16, 2022
  33. Dec 15, 2022
  35. Dec 12, 2022
    • Tobias Bodmer's avatar
      Throw out static widget variable · c5744eae
      Tobias Bodmer authored 
      - static variable gone
- replaced by pointer for each element in hierarchy. (Imagine two persistent trees, total chaos otherwise)
- raw matrix data has column wise sorting. Fix reading and writing code.
- QLineEdit now focuses start of line after setText.
      c5744eae
  37. Dec 07, 2022
  39. Dec 06, 2022
    • Tobias Bodmer's avatar
      Impl. EditText widget for Matrix · dfb4789a
      Tobias Bodmer authored 
      - New Widget which contains an edittext for each matrix element
- self-contained parsing on changes for error highlighting
- moved onTreeWidgetItemDoubleClicked and onTreeWidgetItemChanged to AronTreeWidgetController.h, these GUI actions only concern the Tree widget details, not however the full scope in SkillManagerMonitorWidgetController.h
- in AronTreeWidgetCreator.h: createSimpleTreeViewWidget() now called insertNewTreeViewWidget(). It also directly adds the created widget to the parent, has control flow reasons to add it directly.
 (otherwise we cannot directly overlay custom widgets inside the AronTreeWidgetCreatorVisitor)
 -
      dfb4789a
  41. Nov 15, 2022
  43. Nov 14, 2022
  45. Nov 09, 2022
    • Tobias Bodmer's avatar
      clang format & changed callback for checks · 3a5d0a2d
      Tobias Bodmer authored 
      - finally got clang-format again. (imo made the documents worse though)
- implement callback on changed items in the gui. Attempt to convert them
to aron types. If that fails, the element gets colored red.
      3a5d0a2d
  47. Nov 07, 2022
    • Tobias Bodmer's avatar
      Unique Dict keys, separate edit properties · c32bd844
      Tobias Bodmer authored 
      AronTreeWidgetItem now stores two flags, which column should be
editable. This is necessary, because the parent entry could enable
editing column 0 whilst the current elment can be edited in its value.
Only using the flag of QTreeElement is then too messy.

Also added a parent pointer to the CreatorVisitor. This provides enough
context for a centralized instantiation.

As pointed out: Newly added keys are now unique.
      c32bd844
  49. Oct 11, 2022
    • Tobias Bodmer's avatar
      support list, expandable context menu · 58920b79
      Tobias Bodmer authored 
      - list creates a child tree element per item
  - the key is a numerated index
  - context menu on the item deletes this exact item
- context menu handling now separated on which options are available and
their execution

Bugs to fix:
- Type of Dict not correct (see example "cascaded_list")
- Keys of dict not editable when in list (e.g. type
List<Dict<something>>)

next things to do:
- converters for dict, list, intenum (partially just check)
- tuple & pair
- sanity checks after checking rest of converters
      58920b79
  51. Oct 10, 2022
  53. Sep 28, 2022
    • Tobias Bodmer's avatar
      prevent gui popup for leaf types · 0c03de6f
      Tobias Bodmer authored 
      ... except String atm
      0c03de6f
    • Tobias Bodmer's avatar
      Dict entries expanded in DetailedView · cb0636a5
      Tobias Bodmer authored 
      Inside the SetterVisitor, the code now generates enough children to view
all attributes.

Still TODO:
 - adaptively erase children
 - add context menu to add & remove children
 - check that edits persist / are picked up before execution

Dict Unrelated TODOS:
 - make Leaf types editable in GUI
 - do same treatment for lists
      cb0636a5
  55. Sep 27, 2022