Skip to content
Snippets Groups Projects

Improve armem prediction interface

Merged Philip Scherer requested to merge prediction-improvements into master
All threads resolved!

Closes #99 (closed)

Improves the infrastructure for armem predictions.

This MR's branch is based on the linear-prediction branch, so that should be merged first.

Edited by Rainer Kartmann

Merge request reports

Approval is optional

Merged by Rainer KartmannRainer Kartmann 2 years ago (May 25, 2022 1:40pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Philip Scherer added 56 commits

    added 56 commits

    • 7959d540...60f6e344 - 44 commits from branch master
    • a7eb5e0e - Merge branch 'master' into linear-prediction
    • 238744af - Use entity name as object ID
    • 2a949639 - Put linear prediction control in own group box
    • 70b6ba2c - Add todo about race condition
    • 92844ef3 - Fix race condition, add todo
    • 464dcf92 - Fix visualization of predictions in object pose client
    • 96ade75c - Improve fetching prediction data in SegmentAdapter
    • 8b2a2101 - Move predictObjectPose into ArmarXObjects
    • f07193bc - Merge branch 'linear-prediction' into prediction-improvements
    • e48d6644 - Rename map prefix functions for semantics
    • 283fb965 - ObjectMemory Visu: Predictions with fewer locks
    • a11f9c18 - Merge branch 'linear-prediction' into prediction-improvements

    Compare with previous version

  • Philip Scherer resolved all threads

    resolved all threads

  • Rainer Kartmann added 4 commits

    added 4 commits

    Compare with previous version

  • Next steps: Make server core/provider segments have a memory ID map for engines

  • mentioned in issue #99 (closed)

  • Rainer Kartmann changed the description

    changed the description

  • Philip Scherer added 28 commits

    added 28 commits

    • 2548003a...40574880 - 22 commits from branch master
    • 385dafe2 - Make Reader return BO types for prediction engines
    • ebcb5540 - Add memory implementation for pred. engine support
    • 96d014a3 - Move Prediction.{h,cpp} to armem/core
    • f3b8daaa - Merge branch 'master' into prediction-improvements
    • 2f88ed24 - Replace PredictionEngineSeq in Memory impl
    • 1b02efe6 - Migrate existing prediction engines to new impl

    Compare with previous version

  • Philip Scherer requested review from @RainerKartmann

    requested review from @RainerKartmann

  • added 1 commit

    • 65cf8954 - Revise Predictive: Split into Predictive (base, no children) and...

    Compare with previous version

  • Thanks! I made a few changes to the Predictive class (to avoid the special case in ProviderSegment). It builds, but I haven't tested it yet in run time.

  • Rainer Kartmann marked this merge request as ready

    marked this merge request as ready

  • Rainer Kartmann mentioned in commit 07ac42d3

    mentioned in commit 07ac42d3

  • mentioned in issue #97 (closed)

  • Please register or sign in to reply
    Loading