Skip to content
Snippets Groups Projects

Fix build issue regarding const expressions

Closed Peter Albrecht requested to merge fix/constRemoval into master

The char pointers used for the text in the skill gui were originally const constexpr, but were changed to only const after feedback while merging. This breaks compilation, since constexpr does not imply const anymore after C++17 (source)

Reverting the change fixes compilation. Whether we should instead use const std::string, is another topic.

Merge request reports

Pipeline #17681 passed

Pipeline passed for 0af99334 on fix/constRemoval

Approval is optional

Closed by Peter AlbrechtPeter Albrecht 1 year ago (Jan 31, 2024 12:03am UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading