Skip to content
Snippets Groups Projects

include aron_conversions/framed.h, which is needed to convert FramedPoses as, e.g., in Marker

Open Tilman Daab requested to merge fix/armem-objects-include-for-framed-pose into master
1 unresolved thread

Including RobotAPI/libraries/aron/common/aron_conversions.h is not sufficient to convert aron instances of the Marker class, as common/aron_conversions.h does not include common/aron_conversions/framed.h.

This merge request suggests to add an include of common/aron_conversions/framed.h to armem_objects/aron_conversions.cpp.

An alternative would be to extend common/aron_conversions.h to include common/aron_conversions/framed.h as well. However, as this increases the amount of included code also in cases where it is not needed, I prefer the previously mentioned option, which is reflected in this merge request.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
3 3 #include <RobotAPI/libraries/ArmarXObjects/aron_conversions.h>
4 4 #include <RobotAPI/libraries/armem/core/aron_conversions.h>
5 5 #include <RobotAPI/libraries/aron/common/aron_conversions.h>
6 // for FramedPose, e.g. being used by Marker
7 #include <RobotAPI/libraries/aron/common/aron_conversions/framed.h>
  • Is this still needed? aron/common/aron_conversions.h includes framed.h?

    Either the include was added recently or the ordering of includes in aron_conversions.h has to be adapted.

  • Author Maintainer

    aron/common/aron_conversions.h was added 1 month ago (587ce36a), while this merge request was created 5 months ago. The problem thus might be (here: looks like being) resolved now.

  • Please register or sign in to reply
Please register or sign in to reply
Loading