Skip to content
Snippets Groups Projects

Add Prediction Interface and linear position prediction model to Object Memory

Merged Philip Scherer requested to merge linear-prediction into master
1 unresolved thread

Closes #91 (closed), #96 (closed).

Add linear position prediction to ObjectMemory Segment.

Edited by Rainer Kartmann

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Philip Scherer added 4 commits

    added 4 commits

    • 5104c3b5 - Implement suggestions from Gitlab MR
    • bc2aad20 - Add time offset and window params to ObjMem Visu
    • 864034c7 - Add fallbacks to linear prediction for edge cases
    • ea64a429 - Make ObjPosClientEx visualize multiple predictions

    Compare with previous version

  • Philip Scherer resolved all threads

    resolved all threads

    • Resolved by Philip Scherer

      Some things I noticed while working on this MR:

      • Using std::stringstreams for error messages in BOs is not as great as we thought because it makes the BOs non-copyable, so you can't use them in vectors anymore.
      • Last time, we discussed that predictions should use MemoryIDs that are resolved to the snapshot level. However, I think that object pose predictions require instance indices for disambiguation. In particular, the current code only works if every entity in the instance segment only has a single instance per snapshot. If it has multiple object instances, the predictions will mix up the different objects' poses. I'm not quite sure how to resolve this since ObjectIDs support arbitrary strings as instance names - armem only supports integers, so the conversion would be a little iffy.
    • Resolved by Rainer Kartmann

      Follow up:

      Refactor prediction code from source/RobotAPI/libraries/armem_objects/server/instance/Segment.cpp into the library RobotAPIArmarXObjects (i.e. something like: ObjectPose predict(vector<ObjectPose> poses, time))

  • mentioned in issue #96 (closed)

  • Rainer Kartmann added 47 commits

    added 47 commits

    Compare with previous version

  • Rainer Kartmann added 4 commits

    added 4 commits

    • 2a949639 - Put linear prediction control in own group box
    • 70b6ba2c - Add todo about race condition
    • 92844ef3 - Fix race condition, add todo
    • 464dcf92 - Fix visualization of predictions in object pose client

    Compare with previous version

  • Philip Scherer added 1 commit

    added 1 commit

    • 96ade75c - Improve fetching prediction data in SegmentAdapter

    Compare with previous version

  • Philip Scherer resolved all threads

    resolved all threads

  • Philip Scherer added 1 commit

    added 1 commit

    • 8b2a2101 - Move predictObjectPose into ArmarXObjects

    Compare with previous version

  • Philip Scherer changed the description

    changed the description

  • Philip Scherer added 1 commit

    added 1 commit

    • 854e838b - ObjectMemory Visu: Predictions with fewer locks

    Compare with previous version

  • Philip Scherer added 1 commit

    added 1 commit

    • 283fb965 - ObjectMemory Visu: Predictions with fewer locks

    Compare with previous version

  • added 1 commit

    • 90bbd193 - Do not use armem prediction settings in ArmarXObjects lib

    Compare with previous version

  • Rainer Kartmann marked this merge request as ready

    marked this merge request as ready

  • Rainer Kartmann mentioned in commit 87eff69d

    mentioned in commit 87eff69d

  • Please register or sign in to reply
    Loading