Skip to content
Snippets Groups Projects
Commit fb522d24 authored by Peter Albrecht's avatar Peter Albrecht
Browse files

Removed automatic update of skill details

parent 2cf9a758
No related branches found
No related tags found
1 merge request!406Refactor skill memory GUI
......@@ -107,8 +107,12 @@ namespace armarx::skills::gui
// update cascade
connect(this, &SkillMemoryGUI::updateGui, skillGroupBox, &SkillGroupBox::updateGui);
// we don't want to update the skill details periodically, update can be triggered manually
/*
connect(
this, &SkillMemoryGUI::updateGui, skillDetailGroupBox, &SkillDetailGroupBox::updateGui);
*/
connect(this,
&SkillMemoryGUI::updateGui,
skillExecutionTreeWidget,
......
......@@ -34,8 +34,11 @@ namespace armarx::skills::gui
SkillDetailsTreeWidget::updateContents(const SkillID& skillId, const SkillDescription& descr)
{
// dont touch the widget if the skill id didn't change
// note: this is only relevant when periodic updates are enabled
/*
if (shownSkill.has_value() && skillId == shownSkill.value().skillId)
return;
*/
// check the parameters: did they change?
if (shownSkill.has_value())
......@@ -47,7 +50,7 @@ namespace armarx::skills::gui
// for now, we just overwrite without asking... (and do nothing)
}
// other cases: if the parameter types change, we *have* to reset; else the skill
// (probably) can't be started with the parameters.
// cannot be started with the parameters.
// same goes for the result type.
}
......
......@@ -20,12 +20,6 @@ namespace armarx::skills::gui
return;
}
if (selectedSkill.skillId == c->skillId)
{
// no change
return;
}
selectedSkill.skillId = c->skillId;
emit updateSkillDetails(selectedSkill.skillId);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment