Skip to content
Snippets Groups Projects

add wait_for_eef_pose

Open Markus Grotz requested to merge feature_wait_for_eef_pose into master
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Markus Grotz requested review from @daab

    requested review from @daab

  • assigned to @birr

  • @grotz, thank you for adding this functionality. As I am not a code owner, I wonder why you added me as the reviewer - currently, Python3 ArmarX is coordinated by @birr and @peller. Shall I review it nevertheless? If yes, I would like to give the following comments:

    • The rotational distance is calculated as the euclidean norm of the differences of the Euler angles. Unfortunately, this does not give the correct result. You could, for example, invert one of the rotation matrices, multiply it with the other one and calculate the corresponding rotation angle. This would also save the two function call that convert the existing matrix to Euler angles.

    • Minor: There is a typo in the documentation of the timeout parameter; it should be "wait" rather than "waiy"

  • Timo Birr added 128 commits

    added 128 commits

    Compare with previous version

Please register or sign in to reply
Loading