Update to changes in skill framework

@peller Are the changes in 782dbca9 legitimate fixes, i.e. setting rootProfileDefaults and resultType to nullptr?

requested review from @peller

assigned to @kartmann

Sure, you can do so. But isnt it compiling n your machine? On mine everything compiles on main.

the rootProfileDefaults are defaulted to nullptr, similar for the returntype and the parameterstype, so you shouldnt be forced to set them in the aggregated initializer

For me it did not compile, because the creation of the SkillDescription did not compile, because it did not set the new members of SkillDescription

O.o have to check that. Are you on newest master on robotapi?

Yes, I am on sw/armarx/robot-api@1cfaf630 in RobotAPI and get this in armarx_control:

In file included from /home/rkartmann/code/armarx/skills/control/source/armarx/control/skills/skills/MoveJoints.cpp:1:
/home/rkartmann/code/armarx/skills/control/source/armarx/control/skills/skills/MoveJoints.h: In static member function ‘static armarx::skills::SkillDescription armarx::control::skills::skills::MoveJoints::GetSkillDescription()’:
/home/rkartmann/code/armarx/skills/control/source/armarx/control/skills/skills/MoveJoints.h:38:62: error: could not convert ‘{armarx::skills::SkillID{std::optional<armarx::skills::ProviderID>((std::nullopt, std::nullopt_t())), std::__cxx11::basic_string<char>(((const char*)"MoveJoints"), std::allocator<char>())}, "Moves joints to specified target values using the KinematicUnit", armarx::core::time::Duration::Minutes(((int64_t)1)), armarx::control::skills::skills::MoveJointsParams::ToAronType()()}’ from ‘<brace-enclosed initializer list>’ to ‘armarx::skills::SkillDescription’
                     .parametersType = ParamType::ToAronType()};
                                                              ^

which is fixed by this MR

hm ok. Had the same error in A7. Fixed now on master (somehow on Ub18 you need to explicitly specify the return type I think this is nicer than adding nullptrs)

Fixed by 0e3fbd84 and 2d19ac18

closed