ScenarioManager: auto-discovering all ArmarX packages
This bothered me for a long time ... When (1) creating a new package, (2) setting up a new workspace, (3) working on the robot, you always have to add the ArmarX packages to the Scenario manager. This PR makes this obsolete. ArmarX packages are now automatically detected based on the environment variables.
Much of the code of the scenario manager is now obsolete and can be removed (adding packages is now meaningless).
Merge request reports
Activity
requested review from @kartmann
assigned to @reister
Hm, I am not sure. I guess the original purpose of this feature is to keep your namespace clean. Or in other words, you can decide what your current workspace is. It might be overwhelming if you are presented with all scenarios in your whole workspace.
I just wondered whether we could do a soft version of that: When you search for a scenario that is not in your opened packages, you are shown an empty list as usual. But additionally, you get a hint like "Do you mean in ?" (with the feature you used running in the background). Then you can press the button "Open package and scenario" to quickly get you going.
So that would mean:
- You are still presented with scenarios from your opened packages first
- Only below them, you are presented with scenarios from other packages and given the option to open the package and the scenario at the same time
Of course, this would be more complex and require UI design compared to your change.
What do you think about this?
- Resolved by Fabian Reister
I think, it worked until we decided to introduce more and more packages. There is a search bar so it's still intuitive to find the executable that you are searching for.
I remember that often, you added a package and when opening the ScenarioEditor again, the package was no longer available. And in addition, the scenario that you had created (e.g. in the robotics practical course).
Therefore, my suggestion would be to introduce a filter to only show ArmarX core packages, integration packages and so on. But we can add this in the future.
added 8 commits
-
89a49657...15844519 - 7 commits from branch
master
- 261a2d78 - Merge remote-tracking branch 'origin/master' into...
-
89a49657...15844519 - 7 commits from branch
added 10 commits
-
261a2d78...ab748ebf - 8 commits from branch
master
- 790b5d1f - Merge remote-tracking branch 'origin/master' into...
- ccc5ec17 - finishing implementation
-
261a2d78...ab748ebf - 8 commits from branch
depends on armarx-core!263 (merged)
mentioned in commit e5af0efd