Update of nlohmann::json not handled correctly

Bug Report

Summary and Bug Description

At workspaces of several users, problems with the automated update of nlohmanjson and dependent packages occured. @reister, would it be appropriate to add nlohmann::json as a dependency of RobotAPI?

Current Behavior

(Some existing workspace). For example, axii w add h2t/PriorknowledgeData followed by axii w upgr -m h2t/PriorknowledgeData lead to an error in libRobotAPIArmarXObjects related to nlohmann::json_abi_v3_11_2. This means, despite requesting to upgrade including dependencies, the order of upgrades seems to be wrong or incomplete.

Expected Behavior

All modules dependent on nlohmann::json should be automatically included in the upgrade, if nlohman::json was changed and rebuilding a higher level package depending on this is requested.

Steps to Reproduce

Workspace compiled with the old version of nlohmann::json, upgrade nlohmann::json, upgrade a package depending on it (without being declared to do so).

Diagnosis

Output of axii self report

# Paste output of axii self report here

More Relevant Logs or Screenshots

added 1 deleted label

assigned to @reister

I'm confused:

• If there are some fundamental problems in the workspace, perform a clean build. This is also very important if new dependencies were added. Otherwise, internal CMake variables might not be set correctly.
• When upgrading axii, there should have been an info that a clean build was necessary. Is it missing?

We can add nlohmann::json as a direct dependency to RobotAPI. At the moment it is a transitive dependency (via Simox).

• Does this mean you clean your entire workspace each time you add any package?
• At https://git.h2t.iar.kit.edu/sw/armarx/meta/axii/-/blob/main/CHANGELOG.md?ref_type=heads#release-241220, I could not see any request for a clean build for the last releases. Would you have expected it at this position, or somewhere else?
• Regarding transitive dependencies, at https://git.h2t.iar.kit.edu/sw/armarx/meta/axii/-/blob/main/docs/module_authors/README.md#required_modules there are rules saying they should only be added if it is a public dependency. However, in https://git.h2t.iar.kit.edu/sw/armarx/robot-api/-/blob/master/CMakeLists.txt?ref_type=heads I do not find it at all. Is the CMakeLists.txt of RobotAPI correct/complete?

• No, not necessarily.
• Then this should have been added in this case.
• We cannot enforce proper usage of CMake commands as we intend it. Also RobotAPI is a legacy project. Actually, you have to go through all CMakeLists.txt and identify all dependencies. Eventually, you can also check the CMake summary (which dependencies could be found) and add them to the module definition if needed. Sounds like a hiwi task.

Okay, thanks for the information. So, is the following correct to sum it up?

• If encountering nlohmann-json problems recently: axii w git clean and upgrade again
• On the long term, checking and correcting dependencies throughout the ArmarX code base would be beneficial, if there is capacity to do so.

yes

closed

changed milestone to %Release 25.03.1.0