Fix usage of global variable, remove unused code

source/ArmarXGui/gui-plugins/ScenarioManager/test/DataStructureTest.cpp

@@ -106,12 +106,6 @@ BOOST_AUTO_TEST_CASE(ApplicationDataConsistency)
     }
 }
 
-BOOST_AUTO_TEST_CASE(IceProperties)
-{
-    //    armarx::IceProperties ip = (*apps)[0]->getProperties();
-    //    (*apps)[1]->setProperties(ip);
-    //    BOOST_CHECK_EQUAL((*apps)[0]->getProperties().getProperty("ArmarX.Verbosity"), (*apps)[1]->getProperties().getProperty("ArmarX.Verbosity"));
-}
 
 BOOST_AUTO_TEST_CASE(ApplicationSettersAndGetters)
 {

source/ArmarXGui/gui-plugins/ScenarioManager/test/TestCMakeParser.cpp

@@ -39,24 +39,26 @@ using namespace armarx;
 
 using boost::test_tools::output_test_stream;
 
-PackageBuilder parser = PackageBuilder();
 
 BOOST_AUTO_TEST_CASE(parsePackage)
 {
-    PackagePtr coreP = parser.parsePackage("ArmarXCore");
-    PackagePtr guiP = parser.parsePackage("ArmarXGui");
+    PackageBuilder parser;
 
+    PackagePtr coreP = parser.parsePackage("ArmarXCore");
+    BOOST_REQUIRE(coreP);
     BOOST_CHECK_EQUAL(coreP->getName(), "ArmarXCore");
+
+    PackagePtr guiP = parser.parsePackage("ArmarXGui");
+    BOOST_REQUIRE(guiP);
     BOOST_CHECK_EQUAL(guiP->getName(), "ArmarXGui");
 }
 
 BOOST_AUTO_TEST_CASE(nonexistant_package)
 {
+    PackageBuilder parser;
+
     PackagePtr badP = parser.parsePackage("asjhdbajasda");
-    if (badP != nullptr)
-    {
-        BOOST_ERROR("Parser returned nonexistant package");
-    }
+    BOOST_CHECK_EQUAL(badP, nullptr);
 }