Skip to content

remove the create function of managed ice object

Raphael Grimm requested to merge no_managed_ice_object_create into master

i am for removing this function because:

  • this function does nothing we can't do an other way.
  • it is not enforced to call this function
  • if the function does not do anything useful, having it only causes needless complexity
  • there are several places where managed ice objects are created without calling this function (if we made this function mandatory, we would need to change all these places)
  • if the create function is mandatory, it should take varargs and pass them to the ctor of the MangedIceObject (this would be c++11 only, but with ifdefs we could add this code to the header and keep mca building)

i removed it on some branches and everything works as usual. these branches are all called no_managed_ice_object_create and are in the packages ArmarXCore, ArmarXGui and Spoac. if this branch is merged, we need to merge all branches.

if this branch is not merged, we should make the call to create mandatory (if we have a factory function we should have to call it or it should not exist)

Edited by Raphael Grimm

Merge request reports