Skip to content
Snippets Groups Projects

fixes for warnings from Wpedantic Wall Wextra

Merged fixes for warnings from Wpedantic Wall Wextra
FixForWerror into master
Merged Raphael Grimm requested to merge FixForWerror into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Manfred Kröhnert
  • Manfred Kröhnert
    Manfred Kröhnert @kroehnert started a thread on the diff
    • source/RobotAPI/components/units/ATINetFTUnit.cpp
    212 return true;
    210 213 }
    211 214
    212 void ATINetFTUnit::convertToFTValues(char *receiveBuf, float *ftdata, int ftdataSize)
    215 void ATINetFTUnit::convertToFTValues(char* receiveBuf, float* ftdata, int ftdataSize)
    213 216 {
    214 uint32_t rdt_sequence = ntohl(*(uint32_t*)&receiveBuf[0]);
    215 uint32_t ft_sequence = ntohl(*(uint32_t*)&receiveBuf[4]);
    216 uint32_t status = ntohl(*(uint32_t*)&receiveBuf[8]);
    217
    218 for( int i = 0; i < ftdataSize; i++ ) {
    219 ftdata[i] = float(int32_t(ntohl(*(uint32_t*)&receiveBuf[12 + i * 4])))/ 1000000.0f;
    220 }
    217 //uint32_t rdt_sequence = ntohl(*(uint32_t*)&receiveBuf[0]); //was an unused variable
    218 //uint32_t ft_sequence = ntohl(*(uint32_t*)&receiveBuf[4]); //was an unused variable
    219 //uint32_t status = ntohl(*(uint32_t*)&receiveBuf[8]); //was an unused variable
    • Manfred Kröhnert
      Manfred Kröhnert @kroehnert ·
      Contributor

      @markusgrotz @barcode can these unused variables be commented out to allow compilation with stricter compiler flags?

    • Raphael Grimm
      Raphael Grimm @grimm ·
      Author Maintainer

      since ntohl takes its parameter per value, it is not changed. so nothing changes receiveBuf and it should be safe to remove these lines.

  • Raphael Grimm Added 1 commit:

    Added 1 commit:

    • bcda34fc - FramedPosition now has manually written copy ctor + assign
  • Manfred Kröhnert mentioned in commit 84251404

    mentioned in commit 84251404

  • Manfred Kröhnert Status changed to merged

    Status changed to merged

  • Manfred Kröhnert Mentioned in commit 84251404

    Mentioned in commit 84251404

    • Please register or sign in to reply