From a43cb643c2827638bf1f6472aae9c03973ce90d2 Mon Sep 17 00:00:00 2001
From: Fabian Peller <fabian.peller-konrad@kit.edu>
Date: Sat, 13 May 2023 15:48:28 +0200
Subject: [PATCH] remove reconnection of skill manager gui

---
 .../SkillManagerMonitorWidgetController.cpp         | 13 ++-----------
 .../SkillManagerMonitorWidgetController.h           |  2 --
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.cpp b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.cpp
index 0fba47d76..12f89e9af 100644
--- a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.cpp
+++ b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.cpp
@@ -89,7 +89,7 @@ namespace armarx
         widget.doubleSpinBoxUpdateFreq->setSuffix(" Hz");
 
         refreshSkillsResultTimer = new QTimer(this);
-        refreshSkillsResultTimer->setInterval(1000 / 5); // Keep this stable.
+        refreshSkillsResultTimer->setInterval(1000 / 2); // Keep this stable.
         refreshSkillsResultTimer->start();
 
         connect(widget.doubleSpinBoxUpdateFreq,
@@ -129,15 +129,6 @@ namespace armarx
     {
     }
 
-    void
-    SkillManagerMonitorWidgetController::reconnectToSkillManager()
-    {
-        if (connected)
-        {
-            getProxy(manager, observerName, 1000);
-        }
-    }
-
     void
     SkillManagerMonitorWidgetController::onInitComponent()
     {
@@ -152,6 +143,7 @@ namespace armarx
             QAbstractItemView::EditTrigger::NoEditTriggers);
         widget.treeWidgetSkillDetails->setColumnHidden(3, true);
 
+        getProxy(manager, observerName, 1000);
         connected = true;
     }
 
@@ -191,7 +183,6 @@ namespace armarx
 
         if (!manager)
         {
-            reconnectToSkillManager();
             return;
         }
 
diff --git a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h
index d9a9379bd..59fd812aa 100644
--- a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h
+++ b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h
@@ -70,8 +70,6 @@ namespace armarx
             return "Skills.Manager";
         }
 
-        void reconnectToSkillManager();
-
         void onInitComponent() override;
         void onConnectComponent() override;
         void onDisconnectComponent() override;
-- 
GitLab