diff --git a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h index f3509e228863fc8112d6bfe04c53bf5db08826ce..786f13d869aee2c6c80d7de9058e840ef0305db1 100644 --- a/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h +++ b/source/RobotAPI/gui-plugins/SkillManagerPlugin/SkillManagerMonitorWidgetController.h @@ -80,8 +80,7 @@ namespace armarx { } - // When using this constructor, the new item will be _appended_ to the bottom of the tree! - // Use with care. + // When using this constructor, the new item will be appended to the bottom of the tree! SkillExecutionInfoTreeWidgetItem(const skills::SkillExecutionID& id, QTreeWidget* parent) : QTreeWidgetItem(parent), executionId(id) { diff --git a/source/RobotAPI/interface/skills/SkillProviderInterface.ice b/source/RobotAPI/interface/skills/SkillProviderInterface.ice index e9ea82deb750893da1921f95541816124eb2697f..3066c962e45326fecfdf8f08c6985bb89bf6c3d7 100644 --- a/source/RobotAPI/interface/skills/SkillProviderInterface.ice +++ b/source/RobotAPI/interface/skills/SkillProviderInterface.ice @@ -136,7 +136,6 @@ module armarx { SkillID skillId; string executorName; - string executionSignature; armarx::core::time::dto::DateTime executionStartedTime; string uuid; }; diff --git a/source/RobotAPI/libraries/armem_skills/server/segment/SkillEventSegment.cpp b/source/RobotAPI/libraries/armem_skills/server/segment/SkillEventSegment.cpp index 7b179a615a24432ec8adeb323923a9e1ee85bb76..11dc8d0dfb40953de6acc8f81921884808339376 100644 --- a/source/RobotAPI/libraries/armem_skills/server/segment/SkillEventSegment.cpp +++ b/source/RobotAPI/libraries/armem_skills/server/segment/SkillEventSegment.cpp @@ -63,7 +63,7 @@ namespace armarx::skills::segment [&](const armem::wm::EntityInstance& i) { auto event = i.dataAs<armarx::skills::arondto::SkillStatusUpdate>(); - skills::SkillStatusUpdate up = {}; + skills::SkillStatusUpdate up; armem::fromAron(event, up); if (auto it = ret.find(up.executionId); it != ret.end() && up < it->second) diff --git a/source/RobotAPI/libraries/skills/core/SkillExecutionID.cpp b/source/RobotAPI/libraries/skills/core/SkillExecutionID.cpp index a4a6fd6c72ea2dea91fa049c302d73c05d647fd8..2bf5f3235ba19f60f4475e9fe3d126fbcfec1db9 100644 --- a/source/RobotAPI/libraries/skills/core/SkillExecutionID.cpp +++ b/source/RobotAPI/libraries/skills/core/SkillExecutionID.cpp @@ -4,12 +4,6 @@ namespace armarx { namespace skills { - /*SkillExecutionID::SkillExecutionID(const SkillID& id, - const std::string& executorName, - const armarx::core::time::DateTime& time) : - skillId(id), executorName(executorName), executionStartedTime(time) - { - }*/ skills::manager::dto::SkillExecutionID SkillExecutionID::toManagerIce() const diff --git a/source/RobotAPI/libraries/skills/core/SkillExecutionID.h b/source/RobotAPI/libraries/skills/core/SkillExecutionID.h index c2142f7e59d90a16b7b222756f76ecbe05654109..53fc20a1013f5924c77159580899ae824bd1ad86 100644 --- a/source/RobotAPI/libraries/skills/core/SkillExecutionID.h +++ b/source/RobotAPI/libraries/skills/core/SkillExecutionID.h @@ -27,12 +27,6 @@ namespace armarx static const constexpr char* EXIT_SEPARATOR = "]"; static const constexpr char* SEPARATOR = "@"; - //SkillExecutionID() = delete; - - /*SkillExecutionID(const SkillID& id, - const std::string& executorName, - const armarx::core::time::DateTime& time);*/ - bool operator==(const SkillExecutionID& other) const {