From 100016fe6be44e22e783bd9e43fc0f948d84cf28 Mon Sep 17 00:00:00 2001
From: Fabian Peller <fabian.peller-konrad@kit.edu>
Date: Thu, 18 May 2023 15:27:33 +0200
Subject: [PATCH] add try catch block to make skillManager more robust
---
.../manager/SkillManagerComponentPlugin.cpp | 23 +++++++++++++------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/source/RobotAPI/libraries/skills/manager/SkillManagerComponentPlugin.cpp b/source/RobotAPI/libraries/skills/manager/SkillManagerComponentPlugin.cpp
index 455215311..f0171437b 100644
--- a/source/RobotAPI/libraries/skills/manager/SkillManagerComponentPlugin.cpp
+++ b/source/RobotAPI/libraries/skills/manager/SkillManagerComponentPlugin.cpp
@@ -201,16 +201,25 @@ namespace armarx
{
const auto& n = it->first;
const auto& s = it->second;
- if (s)
+ try
{
- skills::provider::dto::SkillDescriptionMap m = s->getSkillDescriptions();
- ret.insert({n, m});
- ++it;
+ if (s)
+ {
+ skills::provider::dto::SkillDescriptionMap m = s->getSkillDescriptions();
+ ret.insert({n, m});
+ ++it;
+ }
+ else
+ {
+ ARMARX_WARNING << __PRETTY_FUNCTION__ << ": Found disconnected skill provider '"
+ << n << "'. Removing it from skills.";
+ it = skillProviderMap.erase(it);
+ }
}
- else
+ catch (...)
{
- ARMARX_WARNING << __PRETTY_FUNCTION__ << ": Found disconnected skill provider '"
- << n << "'. Removing it from skills.";
+ ARMARX_WARNING << __PRETTY_FUNCTION__ << ": Found buggy skill provider '" << n
+ << "'. Removing it from skills.";
it = skillProviderMap.erase(it);
}
}
--
GitLab